Skip to content

Commit

Permalink
Disable HERMES_ENABLE_DEBUGGER when building Reanimated 2 AAR packa…
Browse files Browse the repository at this point in the history
…ge (#3956)

## Summary

Fixes #3952.

## Test plan

1. Build Reanimated 2 package on CI
2. Create a new RN 0.70.6 app with Reanimated
3. Copy BokehExample to App.js
4. Build the app in release mode for Android
5. Check if the runtime error is gone
  • Loading branch information
tomekzaw committed Jan 17, 2023
1 parent 2972799 commit 9e8ed94
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion android/build.gradle
Expand Up @@ -473,7 +473,7 @@ android {
debug {
externalNativeBuild {
cmake {
if (JS_RUNTIME == "hermes") {
if (JS_RUNTIME == "hermes" && !REANIMATED_PACKAGE_BUILD) {
arguments "-DHERMES_ENABLE_DEBUGGER=1"
} else {
arguments "-DHERMES_ENABLE_DEBUGGER=0"
Expand Down

0 comments on commit 9e8ed94

Please sign in to comment.