Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code from animation classes #1018

Merged
merged 3 commits into from Aug 6, 2020
Merged

Remove dead code from animation classes #1018

merged 3 commits into from Aug 6, 2020

Conversation

jakub-gonet
Copy link
Member

Description

Animation classes weren't used and only getDefaultState was used in backwardCompatibleAnimWrapper.

@jakub-gonet jakub-gonet self-assigned this Jul 26, 2020
jkadamczyk
jkadamczyk approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@jkadamczyk jkadamczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@jakub-gonet jakub-gonet added this to To do in Reanimated Aug 5, 2020
@jakub-gonet jakub-gonet removed this from To do in Reanimated Aug 5, 2020
@jakub-gonet jakub-gonet merged commit 253ed55 into v1 Aug 6, 2020
@jakub-gonet jakub-gonet deleted the @kuba/remove-dead-code-from-animations branch August 6, 2020 14:37
jakub-gonet added a commit that referenced this pull request Aug 12, 2020
@jakub-gonet
[v1] Remove dead code from animation classes (#1018)
1940009
kmagiera pushed a commit that referenced this pull request Aug 13, 2020
@jakub-gonet @kmagiera
[v1] Remove dead code from animation classes (#1018)
dc54ecb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkadamczyk jkadamczyk jkadamczyk approved these changes

Assignees

@jakub-gonet jakub-gonet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jakub-gonet @jkadamczyk