Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isNaN to the globals #1298

Merged
merged 1 commit into from Oct 9, 2020
Merged

Add isNaN to the globals #1298

merged 1 commit into from Oct 9, 2020

Conversation

JonnyBurger
Copy link
Contributor

Make isNaN available inside a worklet.

@terrysahaidak
Copy link
Contributor

Just a little note: it's better to use safer version Number.isNaN

Copy link
Member

@jakub-gonet jakub-gonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What with other things defined as globals?

In particular:

  • NaN
  • Infinity
  • arguments

and all functions listed under "Function properties".

@kmagiera
Copy link
Member

kmagiera commented Oct 9, 2020

merging this one, it appears however that we should work on changing this logic to something more comprahensive. i.e. getting the list from globals directly via Object.getOwnPropertyNames(global) (will need to filter out some of the props as plugin runs on a node environment and exports globally things like os, net, http modules)

@kmagiera kmagiera merged commit 767e12d into software-mansion:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants