Feature: interpolate: Extrapolate left/right #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
December 19, 2020 13:27
|
@terrysahaidak sup dude! Thanks again for being a maintainer on the Wix Goodness Squad Event Cheers ✌️ |
|
Hey, @karol-bisztyga this is yet another PR as a result of our event, could you please assign someone for review. Thanks. |
jakub-gonet
reviewed
Dec 28, 2020
|
It's a solid PR, I'll be happy to merge it, just please make those couple of thing more clear and I think we're good to go 😉 |
|
@karol-bisztyga @jakub-gonet please re-check I have made some changes for this PR ✌️ ☃️ |
karol-bisztyga
requested changes
Jan 11, 2021
karol-bisztyga
approved these changes
Jan 11, 2021
|
For me, it looks OK. @jakub-gonet? |
piaskowyk
approved these changes
Jan 11, 2021
Co-authored-by: Jakub <jakub.gonet@swmansion.com>
Co-authored-by: Jakub <jakub.gonet@swmansion.com>
|
@karol-bisztyga thanks for merging!❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wix Goodness Squad Event
Motivation: to see extrapolating for both sides, just like in v1.
Fixes #1255
Changes
Live example
IDK which example is better currently 2 in this PR
Screen.Recording.2020-12-19.at.16.23.55.mov
Screen.Recording.2020-12-19.at.18.48.46.mov
Checklist