Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DerivedValue to the TS types #1567

Merged
merged 3 commits into from
Dec 28, 2020
Merged

Add DerivedValue to the TS types #1567

merged 3 commits into from
Dec 28, 2020

Conversation

wcandillon
Copy link
Contributor

No description provided.

jakub-gonet
jakub-gonet approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@jakub-gonet jakub-gonet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jakub-gonet jakub-gonet changed the title 💄 Add DerivedValue to the TS types. Add DerivedValue to the TS types. Dec 28, 2020
@jakub-gonet jakub-gonet changed the title Add DerivedValue to the TS types. Add DerivedValue to the TS types Dec 28, 2020
@jakub-gonet jakub-gonet merged commit e9fe0c1 into software-mansion:master Dec 28, 2020
@mym0404
Copy link

mym0404 commented Jan 19, 2021 •
edited

Is this really needed?
In some use case, we may want to declare a value that is changed when the shared value changed and mutable itself.
Is useAnimatedReaction solution about that?

@wcandillon
Copy link
Contributor Author

I would say so but please share your use-case with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakub-gonet jakub-gonet jakub-gonet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wcandillon @mym0404 @jakub-gonet