Use implementation of useSharedValue in mock #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @jakub-gonet @mgambati since you created/reviews v2 mocks lately. |
- previous implementation did lack "memoize" feature, essentially yielding incorrect return in certain cases. - validate hook via test
Andreyco
force-pushed
the
update-useSharedValue-hook
branch
from
aef96b3
to
7bd4251
Compare
jakub-gonet
changed the title
jakub-gonet
approved these changes
Jan 2, 2021
jakub-gonet
changed the title
rpavlovs
pushed a commit
to rpavlovs/react-native-reanimated
that referenced
this pull request
Jan 12, 2021
The previous implementation did lack "memoize" feature, essentially yielding an incorrect return in certain cases. I added mocks of `useSharedValue`'s hook in order to "unmock" this hook and use its implementation in global mock. PR contains hook test. Co-authored-by: Andrej Badin <abadin@gohealth.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation did lack "memoize" feature, essentially yielding incorrect return in certain cases.
I added mocks of
useSharedValue's hook in order to "unmock" this hook and use its implementation in global mock.PR contains hook test.