Handle null deps in hooks #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakub-gonet
reviewed
Jan 8, 2021
jakub-gonet
approved these changes
Jan 8, 2021
rpavlovs
pushed a commit
to rpavlovs/react-native-reanimated
that referenced
this pull request
Jan 12, 2021
## Description
We don't handle the case when `null` is passed as dependencies in either `useAnimatedGestureHandler` or `useAnimatedScrollHandler`. Although in types it's not an option we have to consider that not all of the users use TypeScript.
Automatic casting to boolean works fine here as `!![] === true`.
<details>
<summary>example code</summary>
```
const gestureHandler = useAnimatedGestureHandler({
onActive: (event, ctx) => {
// ...
},
}, null);
```
</details>
## Checklist
- [x] Included code example that can be used to test this change
- [x] Ensured that CI passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We don't handle the case when
nullis passed as dependencies in eitheruseAnimatedGestureHandleroruseAnimatedScrollHandler. Although in types it's not an option we have to consider that not all of the users use TypeScript.Automatic casting to boolean works fine here as
!![] === true.example code
Checklist