RuntimeDecorator: Correctly set global #1833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1cdb5c9.
`CADisplayLink::targetTimestamp` is only available on iOS 10 or newer. So it wouldn't even build.
This automatically transforms the `useFrameProcessor` hook from my VisionCamera.
|
Closed in favor of #1862. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up PR of #1790. Until now,
globalin Worklets was set to a dummy object which just contained__reanimatedWorkletInit. This PR changes this, so that all other global properties that are being set in theRuntimeDecorator::decorateRuntimefunc are also in theglobalobject.This means,
global._LABELreturns the correct label,global._WORKLETreturnstrue, etc.I have decided to make this a follow-up PR, because I am not sure if this has side-effects. I haven't noticed any, but if anyone else does, please let me know. cc @Szymon20000 @karol-bisztyga @piaskowyk
Changes
globalto the hidden global object so you can correctly useglobal.code. (e.g.global._log,global._WORKLET,global._LABEL, ...)global._chronoNow, a function that returns chrono's time_since_epoch (polyfill forperformance.now())