-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Android from source #1837
Closed
mrousavy
wants to merge
36
commits into
software-mansion:master
from
mrousavy:android/build-from-source
Closed
Build Android from source #1837
mrousavy
wants to merge
36
commits into
software-mansion:master
from
mrousavy:android/build-from-source
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1cdb5c9.
`CADisplayLink::targetTimestamp` is only available on iOS 10 or newer. So it wouldn't even build.
This automatically transforms the `useFrameProcessor` hook from my VisionCamera.
Closing because SWM doesn't want to let users build from source. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a follow-up of #1790.
With native worklet APIs being exposed, it became possible for other native libraries to use the Reanimated "workletization" API. This works great for iOS as you just have to include the
<RNReanimated/ShareableValue.h>
header, but since the Android code is being pre-compiled into an.aar
file, it is not possible to include and link the reanimated code in your library without maintaining a full reanimated source code copy inside of your library's code (at least as far as I'm aware)Changes
.aar
packagecreateNPMPackage
with a simplenpm pack
Benefits
With the new architecture and turbomodules becoming more mainstream, all android apps on RN 0.64 and above require the NDK tools to be installed anyways (see the template's build.gradle), so this means users can simply build their project without any additional change (assuming they're on RN 0.64+)
I'm of course always open for other ideas around this problem (not being able to import reanimated headers/code in other libraries), this is just the solution I came up with.