Allow call's input to be a string on Android #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osdnk
commented
Feb 27, 2019
| @@ -19,12 +19,17 @@ public JSCallNode(int nodeID, ReadableMap config, NodesManager nodesManager) { | |||
| @Override | |||
| protected Double evaluate() { | |||
| WritableArray args = Arguments.createArray(); | |||
| for (int i = 0; i < mInputIDs.length; i++) { | |||
| Node node = mNodesManager.findNodeById(mInputIDs[i], Node.class); | |||
| for (int mInputID : mInputIDs) { | |||
There was a problem hiding this comment.
AFAIK this actually allocates an iterator, so it is not merely a tweak
kmagiera
previously requested changes
Mar 4, 2019
| @@ -19,12 +19,17 @@ public JSCallNode(int nodeID, ReadableMap config, NodesManager nodesManager) { | |||
| @Override | |||
| protected Double evaluate() { | |||
| WritableArray args = Arguments.createArray(); | |||
| for (int i = 0; i < mInputIDs.length; i++) { | |||
| Node node = mNodesManager.findNodeById(mInputIDs[i], Node.class); | |||
| for (int mInputID : mInputIDs) { | |||
There was a problem hiding this comment.
Suggested change
| for (int mInputID : mInputIDs) { | |
| for (int i = 0; i < mInputIDs.length; i++) { |
| for (int i = 0; i < mInputIDs.length; i++) { | ||
| Node node = mNodesManager.findNodeById(mInputIDs[i], Node.class); | ||
| for (int mInputID : mInputIDs) { | ||
| Node node = mNodesManager.findNodeById(mInputID, Node.class); |
There was a problem hiding this comment.
Suggested change
| Node node = mNodesManager.findNodeById(mInputID, Node.class); | |
| Node node = mNodesManager.findNodeById(mInputIDs[i], Node.class); |
| @@ -19,12 +19,17 @@ public JSCallNode(int nodeID, ReadableMap config, NodesManager nodesManager) { | |||
| @Override | |||
| protected Double evaluate() { | |||
| WritableArray args = Arguments.createArray(); | |||
| for (int i = 0; i < mInputIDs.length; i++) { | |||
| Node node = mNodesManager.findNodeById(mInputIDs[i], Node.class); | |||
| for (int mInputID : mInputIDs) { | |||
There was a problem hiding this comment.
AFAIK this actually allocates an iterator, so it is not merely a tweak
osdnk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On Android JSCall exception is thrown type of node's value was string
Changes
Added condition for checking if type of node is a string and then handle it properly.