Fix/fix duplicate c++ symbols jsi #2530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
btw the build.gradle + CMakeLists is a bit messy already, I think we can do a few cleanups here and there to reduce it's complexity |
|
Awesome, thanks for this work! I will base an improvement to WatermelonDB on this |
|
@radex 💪 |
osdnk
pushed a commit
to osdnk/react-native-reanimated
that referenced
this pull request
Oct 18, 2021
## Description By compiling `jsi.cpp`, we will have duplicate C++ symbols in the user's app because `jsi.cpp` is compiled multiple times. (once for RN, once for REA, and maybe also for other third party libs) This PR fixes this by re-using the shared/dynamic C++ library `libjsi.so`. Based on: software-mansion#2488 Authors: @mrousavy @piaskowyk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
By compiling
jsi.cpp, we will have duplicate C++ symbols in the user's app becausejsi.cppis compiled multiple times. (once for RN, once for REA, and maybe also for other third party libs)This PR fixes this by re-using the shared/dynamic C++ library
libjsi.so.Based on: #2488
Authors: @mrousavy @piaskowyk