Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump react-native to 0.67.0-rc.2 #2579

Merged
merged 5 commits into from
Oct 28, 2021
Merged

Conversation

kkafar
Copy link
Member

@kkafar kkafar commented Oct 26, 2021

Description

Bump react-native to 0.67.0-rc.2

  • Example project builds (ios & android)
  • ./gradlew build in android/ completes successfully
  • CI passes
  • Test project compiles for RN versions 62-66

@kkafar kkafar requested a review from piaskowyk October 26, 2021 22:04
Copy link
Member Author

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes below

Comment on lines 9 to 11
versions=("0.67.0-rc.2" "0.66.0" "0.65.1" "0.64.1")
version_name=("67" "66" "65" "64")

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was not sure whether I should drop "0.63.3" version. In the end I did, but I'm pointing it out.

@kkafar kkafar marked this pull request as ready for review October 26, 2021 22:15
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert support for 63.3

@kkafar kkafar marked this pull request as draft October 27, 2021 09:31
@kkafar kkafar marked this pull request as ready for review October 28, 2021 09:54
@kkafar kkafar merged commit fe1c049 into master Oct 28, 2021
@kkafar kkafar deleted the @kkafar/rn/upgrade-to-0.67.0-rc.2 branch October 28, 2021 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants