do not mock global.performance when connected to chrome debugger #2761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelknoch
commented
Dec 17, 2021
| @@ -371,7 +371,7 @@ if (!NativeReanimatedModule.useOnlyV1) { | |||
| : (workletValueSetterJS as <T>(value: T) => void) | |||
| ); | |||
|
|
|||
| if (!isWeb() && isConfigured()) { | |||
| if (!isWeb() && !isChromeDebugger() && isConfigured()) { | |||
There was a problem hiding this comment.
i don't know much about the console mocking here, we could also just mock global.performance if really needed:
if (!global.performance && global._chronoNow) {
global.performance = {
now: global._chronoNow,
}
};There was a problem hiding this comment.
even without chrome debugger global.performance and global._chronoNow seem both to be undefined. should we remove the mock in general? I can't see any purpose for it (tested on iOS, maybe things are different on android)
|
would be great to get your opinion on this @piaskowyk, because as far as I can see you recently worked in that area |
|
Hey @michaelknoch 👋 |
2 tasks
mrousavy
added a commit
to mrousavy/react-native-reanimated
that referenced
this pull request
Dec 20, 2021
Alternative solution to software-mansion#2761
piaskowyk
pushed a commit
that referenced
this pull request
Dec 22, 2021
Alternative solution to #2761
aeddi
pushed a commit
to aeddi/react-native-reanimated
that referenced
this pull request
Mar 22, 2022
…tware-mansion#2761) ## Description Description and motivation for this PR. `global._chronoNow` doesn't seem to be defined when connected to chrome debugger but `global.performance` is defined already. So I think there is no need to mock in that case. Fixes software-mansion#2760 ## Changes do not mock `global.performance` when connected to chrome debugger (same behaviour as for web) <!-- ## Screenshots / GIFs <img width="495" alt="Screenshot 2021-12-17 at 12 48 34" src="https://user-images.githubusercontent.com/5617793/146547028-4f6e6b73-154c-4f31-8b59-5ddae9c1e024.png"> Here you can add screenshots / GIFs documenting your change. You can add before / after section if you're changing some behavior. ### Before ### After --> ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [ ] Ensured that CI passes
aeddi
pushed a commit
to aeddi/react-native-reanimated
that referenced
this pull request
Mar 22, 2022
…tware-mansion#2771) Alternative solution to software-mansion#2761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Description and motivation for this PR.
global._chronoNowdoesn't seem to be defined when connected to chrome debugger butglobal.performanceis defined already. So I think there is no need to mock in that case.Fixes #2760
Changes
do not mock
global.performancewhen connected to chrome debugger (same behaviour as for web)Checklist