Added new useScrollViewOffset hook #3438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwasow
force-pushed
the
@kwasow/useScrollViewPosition
branch
from
eb7ce3e
to
7721b97
Compare
piaskowyk
requested changes
Sep 1, 2022
piaskowyk
approved these changes
Sep 2, 2022
tomekzaw
reviewed
Sep 2, 2022
tomekzaw
reviewed
Sep 2, 2022
tomekzaw
reviewed
Sep 2, 2022
tomekzaw
reviewed
Sep 2, 2022
| }, | ||
| }); | ||
|
|
||
| const loremImpsum = `Lorem ipsum dolor sit amet, consectetur adipiscing elit. Pellentesque sit amet ultrices nisl. Sed aliquam vel justo ut maximus. Ut lacinia odio id metus pulvinar, sed imperdiet risus tincidunt. Pellentesque dapibus rutrum metus nec consequat. Nunc ligula turpis, aliquet quis feugiat eu, aliquet ut metus. Maecenas et pellentesque massa, tempor bibendum eros. Duis tempus, mi nec consectetur tempor, mauris nibh volutpat turpis, eu dictum nunc ipsum et lectus. Duis dictum, urna eget imperdiet ullamcorper, urna orci posuere magna, vel consectetur ipsum urna id urna. Vestibulum mollis ex rutrum pulvinar mollis. Morbi vitae dictum velit. Mauris congue nibh at egestas aliquam. Morbi et odio at ligula ullamcorper pellentesque. |
tomekzaw
reviewed
Sep 2, 2022
tomekzaw
reviewed
Sep 2, 2022
piaskowyk
pushed a commit
that referenced
this pull request
Oct 5, 2022
This new hook makes it easy to create animations based on the offset of a ScrollView. Interface: ```js export function useScrollViewOffset( aref: RefObject<Animated.ScrollView> ): SharedValue<number> ``` - [x] Included code example that can be used to test this change - [x] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [x] Updated documentation - [x] Ensured that CI passes
tomekzaw
added a commit
that referenced
this pull request
Jan 20, 2023
## Summary This PR applies code review suggestions from #3438. ## Test plan Build Example app and check if Article progress example works.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description This new hook makes it easy to create animations based on the offset of a ScrollView. Interface: ```js export function useScrollViewOffset( aref: RefObject<Animated.ScrollView> ): SharedValue<number> ``` ## Checklist - [x] Included code example that can be used to test this change - [x] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [x] Updated documentation - [x] Ensured that CI passes
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This PR applies code review suggestions from software-mansion#3438. ## Test plan Build Example app and check if Article progress example works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This new hook makes it easy to create animations based on the offset of a ScrollView.
Interface:
Checklist