Remove Animated and Common symlinks
#3473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
Common directory in android/src/mainAnimated and Common
tomekzaw
changed the title
Animated and CommonAnimated and Common symlinks
piaskowyk
approved these changes
Aug 23, 2022
piaskowyk
pushed a commit
that referenced
this pull request
Oct 5, 2022
This PR removes two symlinks: 1. `Example/Animated` → `src` 2. `android/src/main/Common` → `Common` These symlinks really annoyed everyone with duplicating the search results in their favourite text editor. The Example app works fine after I removed the first symlink. 🤷♂️ The purpose of the second symlink was probably to compile C++ sources from `Common` directory along with these from `android/src/main/cpp`, but I'm not sure. The PR has been tested both on Example and FabricExample app as well as fresh React Native 0.69.4 app. After the changes, both `cpp` directories (Android-only and common) are properly recognized by Android Studio: <img width="529" alt="Android Studio" src="https://user-images.githubusercontent.com/20516055/184398890-8fcb2c99-57cb-4bfe-a5e1-6021a65cd9b2.png"> Debugging C++ code from `Common` directory in Android Studio also works correctly: <img width="1216" alt="Zrzut ekranu 2022-08-12 o 18 25 21" src="https://user-images.githubusercontent.com/20516055/184401616-f357ce8a-0ac3-43bf-b389-ecc5e95d741b.png"> Android Studio version: Chipmunk | 2021.2.1 Patch 1
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Description This PR removes two symlinks: 1. `Example/Animated` → `src` 2. `android/src/main/Common` → `Common` These symlinks really annoyed everyone with duplicating the search results in their favourite text editor. The Example app works fine after I removed the first symlink. 🤷♂️ The purpose of the second symlink was probably to compile C++ sources from `Common` directory along with these from `android/src/main/cpp`, but I'm not sure. The PR has been tested both on Example and FabricExample app as well as fresh React Native 0.69.4 app. After the changes, both `cpp` directories (Android-only and common) are properly recognized by Android Studio: <img width="529" alt="Android Studio" src="https://user-images.githubusercontent.com/20516055/184398890-8fcb2c99-57cb-4bfe-a5e1-6021a65cd9b2.png"> Debugging C++ code from `Common` directory in Android Studio also works correctly: <img width="1216" alt="Zrzut ekranu 2022-08-12 o 18 25 21" src="https://user-images.githubusercontent.com/20516055/184401616-f357ce8a-0ac3-43bf-b389-ecc5e95d741b.png"> Android Studio version: Chipmunk | 2021.2.1 Patch 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes two symlinks:
Example/Animated→srcandroid/src/main/Common→CommonThese symlinks really annoyed everyone with duplicating the search results in their favourite text editor.
The Example app works fine after I removed the first symlink. 🤷♂️
The purpose of the second symlink was probably to compile C++ sources from
Commondirectory along with these fromandroid/src/main/cpp, but I'm not sure.The PR has been tested both on Example and FabricExample app as well as fresh React Native 0.69.4 app.
After the changes, both
cppdirectories (Android-only and common) are properly recognized by Android Studio:Debugging C++ code from
Commondirectory in Android Studio also works correctly:Android Studio version: Chipmunk | 2021.2.1 Patch 1
Changes
Example/Animated→srcandroid/src/main/Common→CommonTest code and steps to reproduce
Checklist