Remove symlink NativeReanimated.native.ts -> NativeReanimated.ts #3492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
changed the title
This symlink causes `pod install` / `gradle sync` (also Android build)
to fail when using latest React Native Community CLI (shipped with
React Native 0.70.0-rc.3) with following stack trace:
```
error ENOENT: no such file or directory, open '/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/react-native-reanimated/src/reanimated2/__mocks__/NativeReanimated.native.ts'.
[!] Invalid `Podfile` file: 859: unexpected token at 'Error: ENOENT: no such file or directory, open '/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/react-native-reanimated/src/reanimated2/__mocks__/NativeReanimated.native.ts'
at Object.openSync (node:fs:599:3)
at Object.readFileSync (node:fs:467:35)
at /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/findComponentDescriptors.js:49:64
at Array.map (<anonymous>)
at findComponentDescriptors (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/findComponentDescriptors.js:49:34)
at Object.dependencyConfig (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/index.js:136:122)
at /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:47:61
at Array.reduce (<anonymous>)
at getDependencyConfig (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:44:51)
at get react-native-reanimated [as react-native-reanimated] (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:99:18)
info Run CLI with --verbose flag for more details.
'.
# from /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/ios/Podfile:11
# -------------------------------------------
# target 'FabricTestExample' do
> config = use_native_modules!
#
# -------------------------------------------
```
The reason for this symlink to exist is not clear to me, as when
NativeReanimated.native.ts file is not present NativeReanimated.ts
should be used by default instead (?).
kkafar
force-pushed
the
@kkafar/remove-symlink
branch
from
728d4ba
to
6b52d8c
Compare
piaskowyk
approved these changes
Sep 1, 2022
piaskowyk
pushed a commit
that referenced
this pull request
Oct 5, 2022
## Description
This symlink causes `pod install` / `gradle sync` (also Android build) to fail when using latest React Native Community CLI (shipped with *React Native 0.70.0-rc.3*) with following stack trace:
```
error ENOENT: no such file or directory, open '/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/react-native-reanimated/src/reanimated2/__mocks__/NativeReanimated.native.ts'.
[!] Invalid `Podfile` file: 859: unexpected token at 'Error: ENOENT: no such file or directory, open '/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/react-native-reanimated/src/reanimated2/__mocks__/NativeReanimated.native.ts'
at Object.openSync (node:fs:599:3)
at Object.readFileSync (node:fs:467:35)
at /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/findComponentDescriptors.js:49:64
at Array.map (<anonymous>)
at findComponentDescriptors (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/findComponentDescriptors.js:49:34)
at Object.dependencyConfig (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/index.js:136:122)
at /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:47:61
at Array.reduce (<anonymous>)
at getDependencyConfig (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:44:51)
at get react-native-reanimated [as react-native-reanimated] (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:99:18)
info Run CLI with --verbose flag for more details.
'.
# from /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/ios/Podfile:11
# -------------------------------------------
# target 'FabricTestExample' do
> config = use_native_modules!
#
# -------------------------------------------
```
The reason for this symlink to exist is not clear to me, as when
NativeReanimated.native.ts file is not present NativeReanimated.ts
should be used by default instead (?).
## Changes
Removed symlink `src/reanimated2/__mocks__/NativeReanimated.native.ts` pointing to `NativeReanimated.ts` in the same directory.
## Test code and steps to reproduce
To reproduce the issue you can try to build project with `react-native-reanimated` & `react-native-screens#b9beeca` (this reference will be valid until the branch introducing support for React Native 0.70.0 is merged to `main` in `react-native-screens` repository.)
## Checklist
- [ ] Ensured that CI passes
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…tware-mansion#3492) ## Description This symlink causes `pod install` / `gradle sync` (also Android build) to fail when using latest React Native Community CLI (shipped with *React Native 0.70.0-rc.3*) with following stack trace: ``` error ENOENT: no such file or directory, open '/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/react-native-reanimated/src/reanimated2/__mocks__/NativeReanimated.native.ts'. [!] Invalid `Podfile` file: 859: unexpected token at 'Error: ENOENT: no such file or directory, open '/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/react-native-reanimated/src/reanimated2/__mocks__/NativeReanimated.native.ts' at Object.openSync (node:fs:599:3) at Object.readFileSync (node:fs:467:35) at /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/findComponentDescriptors.js:49:64 at Array.map (<anonymous>) at findComponentDescriptors (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/findComponentDescriptors.js:49:34) at Object.dependencyConfig (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-platform-android/build/config/index.js:136:122) at /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:47:61 at Array.reduce (<anonymous>) at getDependencyConfig (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:44:51) at get react-native-reanimated [as react-native-reanimated] (/Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/node_modules/@react-native-community/cli-config/build/loadConfig.js:99:18) info Run CLI with --verbose flag for more details. '. # from /Users/kacperkafara/workspace/swm/kkafar@screens/FabricTestExample/ios/Podfile:11 # ------------------------------------------- # target 'FabricTestExample' do > config = use_native_modules! # # ------------------------------------------- ``` The reason for this symlink to exist is not clear to me, as when NativeReanimated.native.ts file is not present NativeReanimated.ts should be used by default instead (?). ## Changes Removed symlink `src/reanimated2/__mocks__/NativeReanimated.native.ts` pointing to `NativeReanimated.ts` in the same directory. ## Test code and steps to reproduce To reproduce the issue you can try to build project with `react-native-reanimated` & `react-native-screens#b9beeca` (this reference will be valid until the branch introducing support for React Native 0.70.0 is merged to `main` in `react-native-screens` repository.) ## Checklist - [ ] Ensured that CI passes Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This symlink causes
pod install/gradle sync(also Android build) to fail when using latest React Native Community CLI (shipped with React Native 0.70.0-rc.3) with following stack trace:The reason for this symlink to exist is not clear to me, as when
NativeReanimated.native.ts file is not present NativeReanimated.ts
should be used by default instead (?).
Changes
Removed symlink
src/reanimated2/__mocks__/NativeReanimated.native.tspointing toNativeReanimated.tsin the same directory.Test code and steps to reproduce
To reproduce the issue you can try to build project with
react-native-reanimated&react-native-screens#b9beeca(this reference will be valid until the branch introducing support for React Native 0.70.0 is merged tomaininreact-native-screensrepository.)Checklist