Add REACT_NATIVE_DOWNLOADS_DIR to specify custom download location
#3552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
pushed a commit
that referenced
this pull request
Oct 6, 2022
…3552) ## Description it's not ideal to download 3rd party libraries multiple times, so i'm proposing to add `REACT_NATIVE_DOWNLOADS_DIR` as react-native to specify a custom download locations. also having a pr for expo: expo/expo#19015 ## Changes add `REACT_NATIVE_DOWNLOADS_DIR` environment variable to specify custom download location ## Test code and steps to reproduce execute `REACT_NATIVE_DOWNLOADS_DIR=$HOME/foo ./gradlew :app:assembleDebug` in Example app and verify whether $HOME/foo contains the download files after builds ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [x] Ensured that CI passes
mthahzan
added a commit
to mthahzan/react-native-mmkv
that referenced
this pull request
Oct 8, 2022
Added support for custom download directory using `REACT_NATIVE_DOWNLOADS_DIR` environment variable. This is copied from software-mansion/react-native-reanimated#3552. Possibly fixes mrousavy#436 and mrousavy#455
mrousavy
pushed a commit
to mrousavy/react-native-mmkv
that referenced
this pull request
Oct 10, 2022
Added support for custom download directory using `REACT_NATIVE_DOWNLOADS_DIR` environment variable. This is copied from software-mansion/react-native-reanimated#3552. Possibly fixes #436 and #455
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…oftware-mansion#3552) ## Description it's not ideal to download 3rd party libraries multiple times, so i'm proposing to add `REACT_NATIVE_DOWNLOADS_DIR` as react-native to specify a custom download locations. also having a pr for expo: expo/expo#19015 ## Changes add `REACT_NATIVE_DOWNLOADS_DIR` environment variable to specify custom download location ## Test code and steps to reproduce execute `REACT_NATIVE_DOWNLOADS_DIR=$HOME/foo ./gradlew :app:assembleDebug` in Example app and verify whether $HOME/foo contains the download files after builds ## Checklist - [ ] Included code example that can be used to test this change - [ ] Updated TS types - [ ] Added TS types tests - [ ] Added unit / integration tests - [ ] Updated documentation - [x] Ensured that CI passes
yuriisalo123
pushed a commit
to yuriisalo123/React-native-mmkv
that referenced
this pull request
Jun 28, 2023
Added support for custom download directory using `REACT_NATIVE_DOWNLOADS_DIR` environment variable. This is copied from software-mansion/react-native-reanimated#3552. Possibly fixes #436 and #455
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
it's not ideal to download 3rd party libraries multiple times, so i'm proposing to add
REACT_NATIVE_DOWNLOADS_DIRas react-native to specify a custom download locations. also having a pr for expo: expo/expo#19015Changes
add
REACT_NATIVE_DOWNLOADS_DIRenvironment variable to specify custom download locationTest code and steps to reproduce
execute
REACT_NATIVE_DOWNLOADS_DIR=$HOME/foo ./gradlew :app:assembleDebugin Example app and verify whether $HOME/foo contains the download files after buildsChecklist