Make measure and scrollTo generic
#3778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
force-pushed
the
@jpiasecki/types/nativemethods
branch
from
d133ead
to
3aa3d16
Compare
tjzel
force-pushed
the
@jpiasecki/types/nativemethods
branch
from
3aa3d16
to
144b8d6
Compare
tjzel
approved these changes
Apr 27, 2023
## Summary _This PR is part of an ongoing effort to get rid of the .d.ts file and use type definitions generated based on the source code._ It's a direct follow-up to #3778. - Added type tests for `NativeMethods`. I still need some guidance with them - what exactly do we want to test there and how. - Added extra type `AnimatedRef<T>` which is an alias to `RefObjectFunction<T>`. Reason for that was in many parts of code we explicitly ask for an `animatedRef` as an argument and it seems just more logical to have an alias for it. ## Test plan 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of an ongoing effort to get rid of the
.d.tsfile and use type definitions generated based on the source code.Changes
measureto be a generic functionscrollToto be a generic functionChecklist