Unify event handling on Paper and Fabric #4012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Feb 3, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary
This PR unifies code responsible for handling events on Paper and Fabric
on both platforms.
## Changes
* Remove `#ifdef` for `registerEventHandler` and make it
renderer-agnostic
* Use `convertObjCObjectToJSIValue` instead of
`convertIdToFollyDynamic`, `folly::toJson` and
`jsi::Value::createFromJsonUtf8` on iOS
* Move Obj-C/JSI conversion functions from `NativeProxy.mm` to
`REAJSIUtils.h`
* Still use JSON as intermediate format between `ReadableMap` and
`jsi::Value` on Android (no known alternatives)
* Pass JNI values to EventHandler function instead of `std::string`
(like on iOS we pass `id<RCTEvent>`)
* Use `const jsi::Value &` for event payload
* Use `const std::string &` for event name
<!--
Android:
* `event == nullptr`
* contains NaN/INF values
* `event->toString()` fail
* `{ NativeMap: null }`
* invalid JSON
* normal case
iOS:
* `event == nil`
* `[event arguments][2]` is not a `NSDictionary`
* contains NaN/INF values
* normal case
-->
## Test plan
Check if `GestureHandlerExample.tsx` and `ScrollViewExample.tsx` work on
all configurations (Paper/Fabric, Android/iOS).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR unifies code responsible for handling events on Paper and Fabric on both platforms.
Changes
#ifdefforregisterEventHandlerand make it renderer-agnosticconvertObjCObjectToJSIValueinstead ofconvertIdToFollyDynamic,folly::toJsonandjsi::Value::createFromJsonUtf8on iOSNativeProxy.mmtoREAJSIUtils.hReadableMapandjsi::Valueon Android (no known alternatives)std::string(like on iOS we passid<RCTEvent>)const jsi::Value &for event payloadconst std::string &for event nameTest plan
Check if
GestureHandlerExample.tsxandScrollViewExample.tsxwork on all configurations (Paper/Fabric, Android/iOS).