Make sensors work with different device orientations #4033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
reviewed
Feb 7, 2023
android/src/main/java/com/swmansion/reanimated/sensor/ReanimatedSensorListener.java
Outdated
Show resolved
Hide resolved
tomekzaw
reviewed
Feb 7, 2023
tomekzaw
approved these changes
Feb 10, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…n#4033) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary - Adds `adjustToInterfaceOrientation` option that adjusts the sensors values to current device orientation - Adds `interfaceOrientation` shared value that contains the current interface orientation - Adds `iosReferenceFrame` option that allows setting ios reference frame. Some reference frames doesn't work for example on iPods but give better results. ## Test plan - `AnimatedSensorExample.tsx` - `CubesExample.tsx` - when device faces north the cubes should rotate in the correct way on every device orientation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adjustToInterfaceOrientationoption that adjusts the sensors values to current device orientationinterfaceOrientationshared value that contains the current interface orientationiosReferenceFrameoption that allows setting ios reference frame. Some reference frames doesn't work for example on iPods but give better results.Test plan
AnimatedSensorExample.tsxCubesExample.tsx- when device faces north the cubes should rotate in the correct way on every device orientation.