[Shared Element Transition] Problem with headers #4036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Feb 10, 2023
...ager/latest/com/swmansion/reanimated/layoutReanimation/ReanimatedNativeHierarchyManager.java
Outdated
Show resolved
Hide resolved
...ager/latest/com/swmansion/reanimated/layoutReanimation/ReanimatedNativeHierarchyManager.java
Outdated
Show resolved
Hide resolved
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary PR contains improvements in snapshotting view properties. - Android - Now animation will start when the screen has an attached header. In effect, the values in the snapshot will be valid. - iOS - I replaced the old approach by detecting the screen header and adding information about header size to the snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR contains improvements in snapshotting view properties.