Refactor NativeProxy on Android #4042
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Feb 10, 2023
There was a problem hiding this comment.
Thanks @graszka22 for this refactor, it really makes things simpler and better-organized. I've left a few suggestions, let me know if they are doable or not.
android/src/fabric/java/com/swmansion/reanimated/NativeProxy.java
Outdated
Show resolved
Hide resolved
android/src/fabric/java/com/swmansion/reanimated/NativeProxy.java
Outdated
Show resolved
Hide resolved
android/src/fabric/java/com/swmansion/reanimated/NativeProxy.java
Outdated
Show resolved
Hide resolved
tomekzaw
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Tested on Example and FabricExample (Android). Well done @graszka22!
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Refactor of `NativeProxy.java` to avoid some code duplication. ## Test plan Run Example app and FabricExample app. Make sure things like keyboard, sensors, layout animations still work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor of
NativeProxy.javato avoid some code duplication.Test plan
Run Example app and FabricExample app. Make sure things like keyboard, sensors, layout animations still work.