Fix host obj reference loop #4082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary Some recent changes (software-mansion#4060 and software-mansion#4024) resulted in introducing a reference loop. The reason was that we started capturing the whole module as host object due to the fact we referenced the module in `defineAnimation` method. As a result, the VM wouldn't deallocate properly and we started getting instance checker crashes on reloads. ## Test plan Start app on iOS. Try out reloading JS several times -> no crash.
This was referenced Jun 14, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some recent changes (#4060 and #4024) resulted in introducing a reference loop. The reason was that we started capturing the whole module as host object due to the fact we referenced the module in
defineAnimationmethod. As a result, the VM wouldn't deallocate properly and we started getting instance checker crashes on reloads.Test plan
Start app on iOS. Try out reloading JS several times -> no crash.