Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shared Element Transition] Restore X-axis origin #4086

Merged
merged 2 commits into from Feb 23, 2023
Merged

[Shared Element Transition] Restore X-axis origin #4086

merged 2 commits into from Feb 23, 2023

Conversation

piaskowyk
Copy link
Member

Summary

Restore the X-axis origin after the shared animation. Previously I was restoring only Y origin to handle the screen with a header, but X origin restoring is required when the screen has its transition animation.

@piaskowyk piaskowyk added this pull request to the merge queue Feb 23, 2023
Merged via the queue into main with commit 4d3b1af Feb 23, 2023
@piaskowyk piaskowyk deleted the @piaskowyk/SET-restore-x-axis branch February 23, 2023 08:50
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@piaskowyk @fluiddot
[Shared Element Transition] Restore X-axis origin (software-mansion#4086
ee65944 
)

## Summary

Restore the X-axis origin after the shared animation. Previously I was
restoring only Y origin to handle the screen with a header, but X origin
restoring is required when the screen has its transition animation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@jwajgelt jwajgelt Awaiting requested review from jwajgelt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@piaskowyk @tomekzaw