Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shared Element Transition] Examples #4088

Merged
merged 5 commits into from Feb 24, 2023
Merged

[Shared Element Transition] Examples #4088

merged 5 commits into from Feb 24, 2023

Conversation

piaskowyk
Copy link
Member

Summary

Added examples with Shared Element Transition to Example app.

@piaskowyk piaskowyk mentioned this pull request Feb 23, 2023
Closed
jwajgelt
jwajgelt approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@jwajgelt jwajgelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the three comments, the examples look good 👍

Example/src/SharedElementTransition/Modals.tsx Outdated Show resolved Hide resolved
Example/src/SharedElementTransition/Modals.tsx Show resolved Hide resolved
Example/src/SharedElementTransition/Modals.tsx Show resolved Hide resolved
tomekzaw
tomekzaw reviewed Feb 23, 2023
View reviewed changes
Example/src/SharedElementTransition/CustomTransition.tsx Outdated Show resolved Hide resolved
Example/src/App.tsx Outdated Show resolved Hide resolved
Example/src/App.tsx Outdated Show resolved Hide resolved
Example/src/SharedElementTransition/Card.tsx Outdated Show resolved Hide resolved
Example/src/SharedElementTransition/CustomTransition.tsx Outdated Show resolved Hide resolved
tomekzaw
tomekzaw approved these changes Feb 24, 2023
View reviewed changes
Example/src/App.tsx Outdated Show resolved Hide resolved
@piaskowyk @tomekzaw
Update Example/src/App.tsx
d9a47dc 
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
@piaskowyk piaskowyk added this pull request to the merge queue Feb 24, 2023
Merged via the queue into main with commit 46cacda Feb 24, 2023
@piaskowyk piaskowyk deleted the @piaskowyk/SET-examples branch February 24, 2023 11:48
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@piaskowyk @tomekzaw @fluiddot
[Shared Element Transition] Examples (software-mansion#4088)
d24a17f 
## Summary

Added examples with Shared Element Transition to Example app.

---------

Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@jwajgelt jwajgelt jwajgelt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@piaskowyk @tomekzaw @jwajgelt