Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup NativeProxy on Android #4116

Merged
merged 5 commits into from
Mar 30, 2023
Merged

Cleanup NativeProxy on Android #4116

merged 5 commits into from
Mar 30, 2023

Conversation

jwajgelt
Copy link
Contributor

Summary

Test plan

tomekzaw
tomekzaw reviewed Feb 27, 2023
View reviewed changes
android/src/main/cpp/NativeProxy.cpp Outdated Show resolved Hide resolved
android/src/main/cpp/NativeProxy.cpp Outdated Show resolved Hide resolved
android/src/main/cpp/NativeProxy.cpp Outdated Show resolved Hide resolved
@jwajgelt jwajgelt force-pushed the @jwajgelt/native_proxy_cleanup branch from df23b16 to b3043b6 Compare February 27, 2023 12:36
@jwajgelt jwajgelt marked this pull request as ready for review March 1, 2023 11:04
tomekzaw
tomekzaw reviewed Mar 3, 2023
View reviewed changes
android/src/main/cpp/NativeProxy.cpp Outdated Show resolved Hide resolved
android/src/main/cpp/NativeProxy.cpp Outdated Show resolved Hide resolved
@kekami kekami mentioned this pull request Mar 9, 2023
Closed
@piaskowyk piaskowyk added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit 2cd16f0 Mar 30, 2023
@piaskowyk piaskowyk deleted the @jwajgelt/native_proxy_cleanup branch March 30, 2023 19:21
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@jwajgelt @fluiddot
Cleanup NativeProxy on Android (software-mansion#4116)
de8e256 
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

<!-- Explain the motivation for this PR. Include "Fixes #<number>" if
applicable. -->

## Test plan

<!-- Provide a minimal but complete code snippet that can be used to
test out this change along with instructions how to run it and a
description of the expected behavior. -->
@renovate renovate bot mentioned this pull request Sep 12, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jwajgelt @tomekzaw @piaskowyk