[Plugin] [5/9] Split ProcessIfWorkletFunction into two functions and improve type checks #4215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the title
…-if-worklet-function-changes
…-if-worklet-function-changes
tjzel
changed the title
tomekzaw
approved these changes
Apr 3, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…improve type checks (software-mansion#4215) ## Summary Previously ProcessIfWorkletFunction was doing both a check if the passed Node was a function and processed it. Now it is separated into two functions that allows some better control flow and type checking. Direct follow-up to software-mansion#4214. ## Test plan Type check on plugin is enough.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…tinguished functions (software-mansion#4216) ## Summary Previously `ProcessForCalleesWorklets` was one big function that was workletizing everything it should (objectHooks and workletizable functions arguments) in its body. Now it's split. Direct follow-up to software-mansion#4215. ## Test plan Type checking and yarn jest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously ProcessIfWorkletFunction was doing both a check if the passed Node was a function and processed it. Now it is separated into two functions that allows some better control flow and type checking.
Direct follow-up to #4214.
Test plan
Type check on plugin is enough.