Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin] [9/9] Split MakeWorklet to two functions #4219

Merged
merged 14 commits into from
Apr 6, 2023
Merged

[Plugin] [9/9] Split MakeWorklet to two functions #4219

merged 14 commits into from
Apr 6, 2023

Conversation

tjzel
Copy link
Contributor

@tjzel tjzel commented Mar 14, 2023 •
edited

Summary

Previously MakeWorklet was one giant function. Now it is split to two files and also has its functions separated from its body for clarity.

Test plan

Yarn jest, test example app, we don't want this to go bad.

@tjzel tjzel changed the title [Plugin] Changes to ProcessWorkletObjectMethod for better logic and adding missed function return types. [Plugin] [9/9] Changes to ProcessWorkletObjectMethod for better logic and adding missed function return types. Mar 14, 2023
@tjzel tjzel changed the title [Plugin] [9/9] Changes to ProcessWorkletObjectMethod for better logic and adding missed function return types. [Plugin] [9/9] Split MakeWorklet to two functions Apr 3, 2023
@tjzel tjzel marked this pull request as ready for review April 3, 2023 15:47
tomekzaw
tomekzaw reviewed Apr 6, 2023
View reviewed changes
plugin/src/makeWorklet.ts Show resolved Hide resolved
plugin/src/makeWorklet.ts Show resolved Hide resolved
tomekzaw
tomekzaw approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@tomekzaw tomekzaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@tjzel tjzel added this pull request to the merge queue Apr 6, 2023
Merged via the queue into main with commit e197568 Apr 6, 2023
@tjzel tjzel deleted the @tjzel/plugin-process-worklet-object-method-changes branch April 6, 2023 15:31
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
@tjzel @fluiddot
[Plugin] [9/9] Split MakeWorklet to two functions (software-mansion#4219
82e6e26 
)

## Summary

Previously `MakeWorklet` was one giant function. Now it is split to two
files and also has its functions separated from its body for clarity.

## Test plan
Yarn jest, test example app, we don't want this to go bad.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomekzaw tomekzaw tomekzaw approved these changes

Assignees
No one assigned
Labels
Area: Plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tjzel @tomekzaw