Fix smooth scroll android #4238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
Mar 17, 2023
android/src/main/java/com/swmansion/reanimated/NativeMethodsHelper.java
Outdated
Show resolved
Hide resolved
piaskowyk
reviewed
Mar 17, 2023
android/src/main/java/com/swmansion/reanimated/NativeMethodsHelper.java
Outdated
Show resolved
Hide resolved
|
To fix CI you need to run: |
Latropos
force-pushed
the
@acynk/fix-smooth-scroll-android
branch
from
35ab46c
to
523b178
Compare
piaskowyk
reviewed
Mar 20, 2023
android/src/main/java/com/swmansion/reanimated/NativeMethodsHelper.java
Outdated
Show resolved
Hide resolved
This was
linked to
issues
Mar 20, 2023
tomekzaw
reviewed
Mar 20, 2023
android/src/main/java/com/swmansion/reanimated/NativeMethodsHelper.java
Outdated
Show resolved
Hide resolved
Latropos
force-pushed
the
@acynk/fix-smooth-scroll-android
branch
from
e917292
to
eebe7e1
Compare
piaskowyk
reviewed
Mar 20, 2023
piaskowyk
reviewed
Mar 20, 2023
android/src/main/java/com/swmansion/reanimated/NativeMethodsHelper.java
Outdated
Show resolved
Hide resolved
Latropos
force-pushed
the
@acynk/fix-smooth-scroll-android
branch
from
eebe7e1
to
f114b35
Compare
Latropos
force-pushed
the
@acynk/fix-smooth-scroll-android
branch
from
8304082
to
7e43304
Compare
piaskowyk
requested changes
Mar 21, 2023
android/src/main/java/com/swmansion/reanimated/NativeMethodsHelper.java
Outdated
Show resolved
Hide resolved
Latropos
force-pushed
the
@acynk/fix-smooth-scroll-android
branch
from
7e43304
to
6f5058e
Compare
piaskowyk
requested changes
Mar 24, 2023
| } else { | ||
| ((ReactScrollView) view).scrollTo((int) x, (int) y); | ||
| } | ||
| (view).scrollTo((int) x, (int) y); |
There was a problem hiding this comment.
Suggested change
| (view).scrollTo((int) x, (int) y); | |
| view.scrollTo(x, y); |
piaskowyk
approved these changes
Mar 30, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Fix this issue: software-mansion#4200 It looks that smoothScrollTo was not always working on Android. According to this stackOverflow [question](https://stackoverflow.com/questions/18673065/scrollto-always-works-smoothscrollto-only-sometimes) we should post a runnable here. <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> Tested 4 cases in our example App: Horizontal and Vertical Scrolls with both animated and instant transitions. <table> <tr><td>Animated</td><td>Not Animated</td></tr> <tr><td> https://user-images.githubusercontent.com/56199675/226555227-3b75ba0b-2861-47ea-955f-56e8c368ad0f.mov </td><td> https://user-images.githubusercontent.com/56199675/226555278-6c0f329a-4417-4271-a337-bd28b41c28f2.mov </td></tr> <tr><td> https://user-images.githubusercontent.com/56199675/226556289-8b527a54-8f8e-4b4d-9ff5-5ce4e05414d3.mov </td><td> https://user-images.githubusercontent.com/56199675/226556339-2dbe1e56-05e5-4923-8f4d-80050ade8bbe.mov </td></tr> </table> --------- Co-authored-by: Aleksandra Cynk <aleksandracynk@aleksandras-mbp.home> Co-authored-by: Aleksandra Cynk <aleksandracynk@swmansion.com> Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix this issue: #4200
It looks that smoothScrollTo was not always working on Android. According to this stackOverflow question we should post a runnable here.
Test plan
Tested 4 cases in our example App: Horizontal and Vertical Scrolls with both animated and instant transitions.
Screen.Recording.2023-03-21.at.09.41.22.mov
Screen.Recording.2023-03-21.at.09.40.54.mov
Screen.Recording.2023-03-21.at.09.45.54.mov
Screen.Recording.2023-03-21.at.09.46.44.mov