Add support for React Native 0.72 #4253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
added a commit
that referenced
this pull request
Mar 23, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Pre-requisite for #4253. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
piaskowyk
approved these changes
Apr 5, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…nsion#4259) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary Pre-requisite for software-mansion#4253. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. -->
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This PR adds support for React Native 0.72.0 as well as bumps React Native version in Example and FabricExample to 0.72.0-rc.1. See https://react-native-community.github.io/upgrade-helper/?from=0.71.3&to=0.72.0-rc.1 for changes. ### TODO - [x] bump version in project root - [x] bump version in Example - [x] bump version in FabricExample - [x] update metro-inspector-proxy patch - [x] change Node version on CI - [x] ~~add `react-native/ReactCommon/react/renderer/components/` to .gitignore?~~ fixed in RN - [x] check if `FBReactNativeSpec` is still required on older versions of RN - [x] fix ESLint errors in Example app - [x] ~~remove `-DRN_FABRIC_ENABLED` from xcproject~~ it's ok ### Checklist - [x] check all configurations (Example/FabricExample, Android/iOS) - iOS / Paper / debug ✅ - iOS / Paper / release ✅ - Android / Paper / debug ✅ - Andorid / Paper / release ✅ - iOS / Fabric / debug ✅ - iOS / Fabric / release ✅ - Android / Fabric / debug ✅ - Android / Fabric / release ✅ - [x] check debugging worklet runtime via Chrome DevTools - [x] check debugging in Android Studio - [x] check production builds ## Test plan
Latropos
reviewed
Oct 2, 2023
Comment on lines
+88
to
+89
| if fabric_enabled && reanimated_major_version == 3 && react_native_minor_version < 72 | ||
| raise "[react-native-reanimated] Reanimated " + reanimated_version + " supports the New Architecture only on the latest minor release of React Native. Please upgrade to React Native 0.72.0+ or downgrade to an older version of Reanimated v3" |
There was a problem hiding this comment.
Here we increase minimum RN version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for React Native 0.72.0 as well as bumps React Native version in Example and FabricExample to 0.72.0-rc.1. See https://react-native-community.github.io/upgrade-helper/?from=0.71.3&to=0.72.0-rc.1 for changes.
TODO
addfixed in RNreact-native/ReactCommon/react/renderer/components/to .gitignore?FBReactNativeSpecis still required on older versions of RNremoveit's ok-DRN_FABRIC_ENABLEDfrom xcprojectChecklist
Test plan