Fix useAnimatedKeyboard animation restart on iOS #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
approved these changes
Mar 23, 2023
This was referenced Mar 23, 2023
Closed
54 tasks
This was referenced Apr 5, 2023
|
Any ETA for release? |
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary When you try to hide animation during keyboard opening, this ends the current animation and starts another one. I added a missing flag setter to prevent the clearing of the displayLink object. ## Test plan | Before | After | | ----------- | ----------- | | <video src="https://user-images.githubusercontent.com/36106620/227270299-5f7cd5e6-21b3-47c3-85fb-2860fb9fbac9.mov" /> | <video src="https://user-images.githubusercontent.com/36106620/227269574-bf94ebc9-3132-49d9-bd2d-f5cd8671990c.mov" /> | Fixes software-mansion#4194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When you try to hide animation during keyboard opening, this ends the current animation and starts another one. I added a missing flag setter to prevent the clearing of the displayLink object.
Test plan
Screen.Recording.2023-03-23.at.17.26.21.mov
Screen.Recording.2023-03-23.at.17.23.40.mov
Fixes #4194