Add missing configureLayoutAnimation on web #4289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is it released already? I'm still facing this issue on web on |
|
@emzet93 Nope, it will be released in 3.1.0 soon. |
|
Thanks 🙏 Will use patch package in the meantime. |
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This PR adds missing `configureLayoutAnimation` method in `JSReanimated` class and resolves a crash when using Layout Animations on web or while debugging in Chrome. Fixes software-mansion#3964. ## Test plan 1. Copy BasicLayoutAnimation.tsx into WebExample/App.tsx 2. Launch WebExample 3. See the error in the browser console 4. Apply this patch 5. ??? 6. Profit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds missing
configureLayoutAnimationmethod inJSReanimatedclass and resolves a crash when using Layout Animations on web or while debugging in Chrome.Fixes #3964.
Test plan