-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add one listener per sensor config #4340
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
requested changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but we need just polish some details. I want to ask you about two another things:
- Add the example to the PR description
- Resolve conflict with the main branch
piaskowyk
requested changes
Apr 21, 2023
piaskowyk
reviewed
Apr 24, 2023
piaskowyk
approved these changes
Apr 24, 2023
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR is to optimise using sensors. Before: Each `useAnimatedSensor` call creates a new native listener that update shared value assigned to it. Now: We identify sensors listeners by sensor type and config properties and the same configurations use the same shared value. ## Test plan - Example app ``` import Animated, { useAnimatedStyle, useAnimatedSensor, SensorType, } from 'react-native-reanimated'; import { StyleSheet, View } from 'react-native'; import React from 'react'; export default function AnimatedSensorExample() { const sensorObject = (color: string, sensorType: any) => { const gravity = useAnimatedSensor(sensorType, { interval: 16 }); console.log(gravity.sensor.value); const animatedStyle = useAnimatedStyle(() => { //console.log(gravity.sensor.value); return { top: -gravity.sensor.value.y * 300, left: gravity.sensor.value.x * 200, }; }); return ( <View style={styles.container}> <Animated.View style={[{...styles.box, backgroundColor: color}, animatedStyle]} /> </View> ) }; return ( <View style={styles.container}> {sensorObject('red', SensorType.GRAVITY)} {sensorObject('blue', SensorType.ACCELEROMETER)} {sensorObject('green', SensorType.GRAVITY)} </View> ); } const styles = StyleSheet.create({ container: { flex: 1, alignItems: 'center', justifyContent: 'center', }, box: { width: 150, height: 150, backgroundColor: 'navy', }, }); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is to optimise using sensors.
Before:
Each
useAnimatedSensor
call creates a new native listener that update shared value assigned to it.Now:
We identify sensors listeners by sensor type and config properties and the same configurations use the same shared value.
Test plan