Persist current screen during fast refresh on web #4343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Apr 11, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
) ## Summary Previously, WebExample used to return to home screen after each fast refresh which was quite a poor developer experience. This PR adds linking so that the current screen persists. Note that the missing back button after fast refresh is a well-known issue in react-navigation for web but fortunately the browser back button works just fine. https://user-images.githubusercontent.com/20516055/230615121-4b6d96db-23ca-4540-974a-0f76f9869bc2.mp4 ## Test plan 1. Launch WebExample 2. Open Bokeh example 3. Save BokehExample.tsx to trigger fast refresh 4. The app shouldn't go back to home screen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously, WebExample used to return to home screen after each fast refresh which was quite a poor developer experience. This PR adds linking so that the current screen persists. Note that the missing back button after fast refresh is a well-known issue in react-navigation for web but fortunately the browser back button works just fine.
Nagranie.z.ekranu.2023-04-7.o.15.11.55.mp4
Test plan