Make single instance assertion work with Gradle Configuration Cache #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…oftware-mansion#4350) ## Summary Makes single instance assertion not break builds when using [Gradle Configuration Cache](https://docs.gradle.org/current/userguide/configuration_cache.html#config_cache:intro). Related: software-mansion/react-native-gesture-handler#2453 ## Test plan Enable Gradle Configuration Cache by adding `org.gradle.unsafe.configuration-cache=true` in the `gradle.properties` file. If testing on the Example app, remove `disableMultipleInstancesCheck=true`. Build the app with and without this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes single instance assertion not break builds when using Gradle Configuration Cache.
Related: software-mansion/react-native-gesture-handler#2453
Test plan
Enable Gradle Configuration Cache by adding
org.gradle.unsafe.configuration-cache=truein thegradle.propertiesfile. If testing on the Example app, removedisableMultipleInstancesCheck=true.Build the app with and without this PR.