Format Babel plugin test inputs #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
approved these changes
Apr 12, 2023
This reverts commit 13a0d6c.
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
## Summary This PR changes the way how JavaScript code snippets are embedded in Reanimated Babel plugin unit tests so that the code can be properly formatted and indented using Prettier. For details on `--embedded-language-formatting`, see [here](https://prettier.io/blog/2020/08/24/2.1.0.html) and [here](https://github.com/thorn0/prettier/blob/master/src/language-js/embed.js). Unfortunately, it looks like currently Prettier doesn't support `js` code tag directly (see prettier/prettier#5993). The workaround is to use `html` code tag and embed the JavaScript code in HTML `<script>` tag. > **Note** > Dear future reader, if you wish to embed TypeScript code, e.g. `useSharedValue<number>(42)`, you will need to specify `lang="ts"` attribute for the `<script>` tag and also modify the implementation of `runPlugin` function. ## Test plan 1. Break formatting in some code input in `__tests__/plugin.test.js` 2. Confirm that `yarn lint:js` fails 3. Run `yarn format:js` 4. Confirm that the file has been formatted properly 5. Break formatting again 6. Stage the changes 7. Confirm that `git commit` fails due to an empty commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR changes the way how JavaScript code snippets are embedded in Reanimated Babel plugin unit tests so that the code can be properly formatted and indented using Prettier.
For details on
--embedded-language-formatting, see here and here. Unfortunately, it looks like currently Prettier doesn't supportjscode tag directly (see prettier/prettier#5993). The workaround is to usehtmlcode tag and embed the JavaScript code in HTML<script>tag.Test plan
__tests__/plugin.test.jsyarn lint:jsfailsyarn format:jsgit commitfails due to an empty commit