doc: added important tip when using android device #4357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
requested changes
Apr 13, 2023
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com>
|
I've implemented the changes you requested |
piaskowyk
reviewed
Apr 13, 2023
Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
|
@piaskowyk suggestion implemented |
|
@Chinedu19 Thanks, can you please propagate this change to |
Done |
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
…4357) <!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary <!-- Explain the motivation for this PR. Include "Fixes #<number>" if applicable. --> This pull request aims to improve the documentation on [Events Fundamentals](https://docs.swmansion.com/react-native-reanimated/docs/fundamentals/events/) by adding instructions for how to set up event handlers on Android devices. Many developers, including myself, have had issues practicing the example on Android devices, which can be confusing for those who are not familiar with *react-native-gesture-handler*. This addition would make it easier for developers to practice using event handlers with *react-native-reanimated* on Android devices directly from the docs and help avoid spending time researching why it isn't working. ## Changes Made This pull request adds a new section to the Events Fundamentals documentation that explains how to enable event handlers on Android devices. It includes simple instructions and code example to help developers enable the event handlers. ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> As this is a documentation update, tests are not applicable. However, reviewers can follow the instructions provided in the new section and verify that the event handlers are working correctly on Android devices. --------- Co-authored-by: Tomek Zawadzki <tomekzawadzki98@gmail.com> Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request aims to improve the documentation on Events Fundamentals by adding instructions for how to set up event handlers on Android devices. Many developers, including myself, have had issues practicing the example on Android devices, which can be confusing for those who are not familiar with react-native-gesture-handler.
This addition would make it easier for developers to practice using event handlers with react-native-reanimated on Android devices directly from the docs and help avoid spending time researching why it isn't working.
Changes Made
This pull request adds a new section to the Events Fundamentals documentation that explains how to enable event handlers on Android devices. It includes simple instructions and code example to help developers enable the event handlers.
Test plan
As this is a documentation update, tests are not applicable. However, reviewers can follow the instructions provided in the new section and verify that the event handlers are working correctly on Android devices.