Add scrollViewOffset prop to AnimatedScrollView #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piaskowyk
reviewed
May 18, 2023
mstach60161
deleted the
@mstach60161/add-scrollViewOffsetProp-to-AnimatedScrollView
branch
fluiddot
pushed a commit
to wordpress-mobile/react-native-reanimated
that referenced
this pull request
Jun 5, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR moves logic from `useScrollViewOffset` hook to `Animated.ScrollView` prop. The API of `useScrollViewOffset` is a bit cumbersome, because we need to pass the same `ref` to both `ScrollView` and hook. Now we just need to pass variable with type `ScrollValue<number>` to `Animated.ScrollView` and when Scroll View changes its position, our value is updated ## Test plan - Example app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves logic from
useScrollViewOffsethook toAnimated.ScrollViewprop.The API of
useScrollViewOffsetis a bit cumbersome, because we need to pass the samerefto bothScrollViewand hook.Now we just need to pass variable with type
ScrollValue<number>toAnimated.ScrollViewand when Scroll View changes its position, our value is updatedTest plan