Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore header back button after reload on web #4453

Merged
merged 3 commits into from
May 16, 2023

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented May 15, 2023

Summary

Currently, the header back button disappears on page reload. This PR adds a back button that navigates to the home screen on each example screen.

Acknowledgements

Thanks @kacperkapusciak for showing me headerLeft prop and @react-navigation/elements package.

Test plan

  1. Open WebExample
  2. Open Bubbles example
  3. Reload the page
  4. Verify that header back button is visible

Copy link
Contributor

@tjzel tjzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Killer feature with dark mode 🕶️

@tomekzaw tomekzaw added this pull request to the merge queue May 16, 2023
Merged via the queue into main with commit 46bef33 May 16, 2023
5 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/fix-web-back-button branch May 16, 2023 07:00
fluiddot pushed a commit to wordpress-mobile/react-native-reanimated that referenced this pull request Jun 5, 2023
## Summary

Currently, the header back button disappears on page reload. This PR
adds a back button that navigates to the home screen on each example
screen.

## Acknowledgements

Thanks @kacperkapusciak for showing me `headerLeft` prop and
`@react-navigation/elements` package.

## Test plan

1. Open WebExample
2. Open Bubbles example 
3. Reload the page
4. Verify that header back button is visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants