Fix cyclic object detection in makeShareableCloneRecursive

[tomekzaw]

Summary

This PR improves the developer experience when playing around with Reanimated's internals takes a very bad turn.

Currently, while cloning shareables, we check for cycles by storing the cloned object at some depth:

react-native-reanimated/src/reanimated2/shareables.ts

Line 103 in 4ebd011

processedObjectAtThresholdDepth = value;

Sometimes (not exactly sure when) we clear this variable so we don't hold it forever:

react-native-reanimated/src/reanimated2/shareables.ts

Line 110 in 4ebd011

processedObjectAtThresholdDepth = undefined;

However, it may happen that while we're deep down in the tree, the function will be called with depth = 0 which resets the store and thus breaks our cyclic object detection mechanism, resulting in a well-known "Maximum call stack exceeded" error, like here:

Here's the place where we call makeShareableClone recursively without passing depth:

react-native-reanimated/src/reanimated2/shareables.ts

Lines 157 to 160 in 4ebd011

	toAdapt.__initData = makeShareableCloneRecursive(
	value.__initData,
	true
	);

This PR adds the missing argument.

Before	After

Test plan

1. Add 'worklet'; directive in runOnUI function in threads.ts
2. Comment out makeShareableCloneRecursive(worklet); inside runOnUI function body
3. Call the following code:

runOnUI(() => {
  'worklet';
  console.log(_WORKLET, 'Hello from the UI thread!');
  runOnUI;
})();

[kmagiera]

+1