-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject _WORKLET
to RN runtime
#4511
Conversation
where i inject |
@tomekzaw is there an estimate to when this will get merged or should i just fork it 😁? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting this has to be added in three places instead of just one, but what can you do 🤷
Once we merge #4523 it will be only two places (one for each platform), and once we cleanup runtime initialization hopefully it will be just one 😄 |
Co-authored-by: Tymoteusz Boba <tymoteusz.boba@swmansion.com>
14fb217
to
cc8531c
Compare
According to my investigation, in out code is possible to call worklet function before globals initialisation -
|
Great to see this merged. Will it make it into a release soon? |
Yep, we're releasing 3.3.0 today. |
Summary
Fixes #4506 and fixes #4507.
Test plan