Fix animations not running when Chrome Debugger is attached #4568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
piaskowyk
approved these changes
Jun 14, 2023
|
This works! |
Latropos
pushed a commit
that referenced
this pull request
Jun 20, 2023
## Summary This PR fixes a bug in v3 which prevents animations from running when Chrome Debugger is attached (or, in general, when web implementation of Reanimated is used). Originally reported by @coayscue. ## Test plan In order to reproduce the issue, you can simply force use web implementation in `PlatformChecker.ts`: ```diff export function isChromeDebugger(): boolean { - return !(global as any).nativeCallSyncHook || (global as any).__REMOTEDEV__; + return true; } ``` When testing gesture-based examples, you will also need to make this change in `gesture.ts`: ```diff export function isRemoteDebuggingEnabled(): boolean { // react-native-reanimated checks if in remote debugging in the same way // @ts-ignore global is available but node types are not included - return !(global as any).nativeCallSyncHook || (global as any).__REMOTEDEV__; + return true; } ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in v3 which prevents animations from running when Chrome Debugger is attached (or, in general, when web implementation of Reanimated is used). Originally reported by @coayscue.
Test plan
In order to reproduce the issue, you can simply force use web implementation in
PlatformChecker.ts:export function isChromeDebugger(): boolean { - return !(global as any).nativeCallSyncHook || (global as any).__REMOTEDEV__; + return true; }When testing gesture-based examples, you will also need to make this change in
gesture.ts:export function isRemoteDebuggingEnabled(): boolean { // react-native-reanimated checks if in remote debugging in the same way // @ts-ignore global is available but node types are not included - return !(global as any).nativeCallSyncHook || (global as any).__REMOTEDEV__; + return true; }