Fix runOnJS on Web and make it asynchronous #4572
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is amending some changes from #4276 where we exchanged
setImmediates
forqueueMicrotask
for_scheduneOnJS
.queueMicrotask
does not take any arguments, only a callback and the change of behaviour stemming from this was not considered inrunOnJS
implementation. This PR fixes this and also makesrunOnJS
actually call_scheduleOnJS
on web, making it asynchronous and consistent with general behavior ofrunOnJS
- before it was unreachable code on web since it would simply return the provided function that was called synchronously.Test plan
Run WebExample and see that now
runOnJS
is working properly. I used the following snippet:Before:
After:
![Screenshot 2023-06-14 at 13 45 11](https://private-user-images.githubusercontent.com/40713406/245899400-23eb27df-f2db-4e18-ad68-bcae37282e0c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgyODc3OTYsIm5iZiI6MTcxODI4NzQ5NiwicGF0aCI6Ii80MDcxMzQwNi8yNDU4OTk0MDAtMjNlYjI3ZGYtZjJkYi00ZTE4LWFkNjgtYmNhZTM3MjgyZTBjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MTMlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjEzVDE0MDQ1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEwY2VmNmM5M2U1MTQ0NTg3NzE5ZTBiN2Y2NTBkZGFjOWQ4YWY1ZDU1ZWM3MThkMzM3NWRjMWU2NjQ1ZWUwYTMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.S3spyA0QS4CREdgFbDHQTgmGLJvNbVM5ajKLIS_YKOs)