Fix ChoreographerCallback double execution

[piaskowyk]

Summary

This PR fixes an issue with long animations. On Android, it was possible to execute ChoreographerCallback twice during the same frame (after frame drop). In effect, existing animations were canceled due to this if-condition in requestAnimationFrame method:

nativeRequestAnimationFrame((timestamp) => {
  if (lastNativeAnimationFrameTimestamp >= timestamp) {
    // Make sure we only execute the callbacks once for a given frame
    return;
  }
...

To fix it, I moved this check to the native code. When double execution happens I skip the execution of the JS callback, but I still need to schedule another choreographer callback.

How to test it?

final long[] lastTimestamp = {0};
new GuardedFrameCallback(context) {
  @Override
  protected void doFrameGuarded(long frameTimeNanos) {
    if (lastTimestamp[0] == frameTimeNanos) {
      Log.w("test");
    }
    onAnimationFrame(frameTimeNanos);
    lastTimestamp[0] = frameTimeNanos;
  }
}

Before

• Open SVGExample
• Set a breakpoint in Android Studio at line Log.w("test");
• Wait some time until the breakpoint hit
• Pass breakpoint
• Animation will stop ❌

After

• Open SVGExample
• Set a breakpoint in Android Studio at line Log.w("test");
• Wait some time until the breakpoint hit
• Pass breakpoint
• Animation will keep going ✅

[kmagiera]

Looks good but please take a look at my comments prior to merging.

[tlow92]

I'm not 100% sure if this really is related but I want to inform you nonetheless:
I faced this issue on latest stable 3.3.0 and applied your fix. It seemed to have fixed my initial issue of canceled animations.
But I also use gorhom/bottom-sheet (uses reanimated) and when the animation for the sheet is opened during an already active animation running it seems to cancel the other animations.

After some investigating I think the behaviour is like this:

• So if sheet opening is triggered before other animations started everything is fine.
• If sheet is opened after other animations finished it's also fine.
• If sheet is opened after other animations started but not finished yet they will be canceled.

Unfortunately I can not provide a reproducible demo right now due to lack of time and my project is very complex, but maybe it helps in case there are other hints to a possible issue.

Edit: To be clear this issue is not happening on 2.14.4

[piaskowyk]

Hey @tlow92 👋 Thanks for your report! It seems like a different problem, could you open a new issue with it?