Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unregister commit hook on Android #4658

Merged
merged 2 commits into from
Jul 3, 2023
Merged

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Jul 1, 2023

Summary

This PR fixes the following crash on Android Fabric:

crash

Test plan

  1. Launch FabricExample on Android
  2. Open BubblesExample
  3. Reload the app a few times by clicking r

@tomekzaw tomekzaw requested a review from piaskowyk July 2, 2023 21:17
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@tomekzaw tomekzaw added this pull request to the merge queue Jul 3, 2023
Merged via the queue into main with commit 2ed26a6 Jul 3, 2023
5 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/unregister-commit-hook branch July 3, 2023 07:33
Latropos pushed a commit that referenced this pull request Jul 3, 2023
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

This PR fixes the following crash on Android Fabric:

<img width="1624" alt="crash"
src="https://github.com/software-mansion/react-native-reanimated/assets/20516055/2e2670bf-a633-450e-b4a8-9fc058d80da9">

## Test plan

1. Launch FabricExample on Android
2. Open BubblesExample
3. Reload the app a few times by clicking <kbd>r</kbd>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants