Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the following TODO:
react-native-reanimated/src/createAnimatedComponent.tsx
Lines 363 to 366 in 1359a11
Previously, we would schedule a worklet via
runOnJS
for each individual unmounted animated component. Each worklet would call JSI binding_removeFromPropsRegistry
. This PR adds batching layer on JS context and changes the semantics of_removeFromPropsRegistry
so that it accepts an array of view tags to remove from PropsRegistry.Test plan
PropsRegistry.cpp
PropsRegistry.ts
function flush() { if (__DEV__ && !global._IS_FABRIC) { throw new Error('PropsRegistry is only available on Fabric'); } + console.log(viewTags.length); runOnUI(removeFromPropsRegistryOnUI)(viewTags); viewTags = []; }
FabricExample → ChessboardExample.tsx