Remove location property in worklets for production builds #4695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
reviewed
Jul 10, 2023
tomekzaw
approved these changes
Jul 11, 2023
piaskowyk
approved these changes
Jul 11, 2023
Latropos
pushed a commit
that referenced
this pull request
Jul 11, 2023
## Summary Currently we inject `location` property in worklets - which is there for debugging purposes - even in production build. This PR corrects this. Fixes: #4689 ## Test plan Added a new test suite in plugin. Also ran production android Example just to be sure.
Latropos
pushed a commit
that referenced
this pull request
Jul 13, 2023
## Summary Currently we inject `location` property in worklets - which is there for debugging purposes - even in production build. This PR corrects this. Fixes: #4689 ## Test plan Added a new test suite in plugin. Also ran production android Example just to be sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently we inject
locationproperty in worklets - which is there for debugging purposes - even in production build. This PR corrects this.Fixes: #4689
Test plan
Added a new test suite in plugin. Also ran production android Example just to be sure.