Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Intl in worklets #4717

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add support for Intl in worklets #4717

merged 1 commit into from
Jul 12, 2023

Conversation

tomekzaw
Copy link
Member

@tomekzaw tomekzaw commented Jul 12, 2023 •
edited

Summary

Fixes #4714.

Test plan

const handlePress = () => {
  runOnUI(() => {
    const formatter = new Intl.NumberFormat('en');
    const result = formatter.format(Math.random() * 1_000_000);
    console.log(_WORKLET, result);
  })();
};

@tomekzaw tomekzaw mentioned this pull request Jul 12, 2023
Closed
@tomekzaw tomekzaw requested a review from tjzel July 12, 2023 10:18
@tomekzaw tomekzaw added this pull request to the merge queue Jul 12, 2023
Merged via the queue into main with commit 7382019 Jul 12, 2023
1 check passed
@tomekzaw tomekzaw deleted the @tomekzaw/intl branch July 12, 2023 11:15
@tjzel
Copy link
Contributor

tjzel commented Jul 12, 2023

👏

Latropos pushed a commit that referenced this pull request Jul 13, 2023
@tomekzaw
Add support for Intl in worklets (#4717)
557db81 
<!-- Thanks for submitting a pull request! We appreciate you spending
the time to work on these changes. Please follow the template so that
the reviewers can easily understand what the code changes affect. -->

## Summary

Fixes #4714.

## Test plan

<!-- Provide a minimal but complete code snippet that can be used to
test out this change along with instructions how to run it and a
description of the expected behavior. -->

```ts
const handlePress = () => {
  runOnUI(() => {
    const formatter = new Intl.NumberFormat('en');
    const result = formatter.format(Math.random() * 1_000_000);
    console.log(_WORKLET, result);
  })();
};
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@tjzel tjzel Awaiting requested review from tjzel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intl is not available in reanimated
3 participants
@tomekzaw @tjzel @piaskowyk