Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detected debug version of the worklet in release bundle #4732

Merged
merged 6 commits into from
Jul 17, 2023

Conversation

piaskowyk
Copy link
Member

@piaskowyk piaskowyk commented Jul 13, 2023

Summary

Fixes: #4690

It may happen when one of the user dependencies provided transpiled code with debug version of the Reanimated plugin. In effect, we have a debug version of the work in your release bundle. This might lead to unexpected issues or errors. 馃槩

I created issue with description how to fix this issue: #4737

@piaskowyk piaskowyk changed the title @piaskowyk/fix version delete Detected debug version of the worklet in release bundle Jul 13, 2023
@piaskowyk
Copy link
Member Author

piaskowyk commented Jul 13, 2023

What we want to do in this case? Just ignore or throw exception and crash application?

src/reanimated2/shareables.ts Show resolved Hide resolved
src/reanimated2/shareables.ts Outdated Show resolved Hide resolved
Co-authored-by: Tomek Zawadzki <tomasz.zawadzki@swmansion.com>
@piaskowyk piaskowyk requested a review from tomekzaw July 14, 2023 07:04
@piaskowyk piaskowyk added this pull request to the merge queue Jul 17, 2023
Merged via the queue into main with commit 76b3947 Jul 17, 2023
1 check passed
@piaskowyk piaskowyk deleted the @piaskowyk/fix-version-delete branch July 17, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[android][release] makeShareableCloneRecursive Call Stack Size Exceeded
3 participants