Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel animation for modals #4776

Merged
merged 4 commits into from
Jul 25, 2023
Merged

Cancel animation for modals #4776

merged 4 commits into from
Jul 25, 2023

Conversation

kadikraman
Copy link
Contributor

@kadikraman kadikraman commented Jul 19, 2023 •
edited

Summary

Fixes #4422

Fixes the bug with Android freezing when Layout Animations are used in a modal.

Credit goes to @bfricka for the fix #4422 (comment)

Test plan

  1. clone the example repository https://github.com/ceceppa/reanimated-3-bug
  2. apply the fix in this PR (or copy the code into your own project)
  3. build and run on Android
  4. open the model
  5. close the modal
  6. open the modal again -> without the fix in this PR, this will fail as the UI becomes unresponsive

@tomekzaw
Copy link
Member

Hey @kadikraman, thanks for submitting this PR! Looks good to me, but we'll need to test it just to be sure.

@piaskowyk piaskowyk self-assigned this Jul 20, 2023
@piaskowyk piaskowyk self-requested a review July 20, 2023 10:09
@piaskowyk
Copy link
Member

@kadikraman Thanks for the PR! 🙌 I tested it and everything works as expected 🎉

piaskowyk
piaskowyk approved these changes Jul 24, 2023
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@piaskowyk piaskowyk added this pull request to the merge queue Jul 25, 2023
Merged via the queue into software-mansion:main with commit 4918602 Jul 25, 2023
5 checks passed
@renovate renovate bot mentioned this pull request Aug 29, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

Assignees

@piaskowyk piaskowyk

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@kadikraman @tomekzaw @piaskowyk